Greg (gregstoll) wrote in suggestions,
Greg
gregstoll
suggestions

Expose reply_count to flat interface call "getfriendspage"

Title
Expose reply_count to flat interface call "getfriendspage"

Short, concise description of the idea
The API call "getfriendspage" returns the reply_count for entries if called through the XML-RPC interface, but not if called through the flat interface.

Full description of the idea
It looks to be a simple change - currently line 3450 of cgi-bin/ljprotocol.pl has a list of keywords that are used to get the post properties for the flat interface. It reads

foreach my $f (qw(subject_raw journalname journaltype postername postertype ditemid security)) {

and it should read

foreach my $f (qw(subject_raw journalname journaltype postername postertype ditemid security reply_count)) {

An ordered list of benefits
  • Application developers would be able to choose between the flat and XML-RPC interfaces based on what is convenient, knowing that the same results will be returned from both.
An ordered list of problems/issues involved
  • A small amount of testing should be done. I don't believe this will cause any problems, since the next line of code checks to make sure the property exists before reading it, and this should be set all the time regardless.
Tags: clients and apps, security, § no status
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 5 comments